• Avi Drissman's avatar
    Fix unsafe and leaky uses of CFDictionaries · 3ed935aa
    Avi Drissman authored
    1. Creating a CFDictionary with null callbacks is almost certainly
    not something you want to do. It is not bridgeable with NSDictionary,
    and the normal semantics of retain/release do not apply. It is
    *unsafe* to put autoreleased items into such a dictionary.
    There is no guarantee that the items won't be deallocated out from
    underneath the dictionary.
    
    2. CFDictionarySetValue does *not* take ownership. No matter if
    the dictionary has retain/release semantics or not, assuming
    ownership takeover will leak.
    
    Bug: none
    Change-Id: I6e3cae093e61ab2a42af7b0052231d00fa4a71b3
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391208Reviewed-by: default avatarLeonard Grey <lgrey@chromium.org>
    Reviewed-by: default avatarMartin Kreichgauer <martinkr@google.com>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#804583}
    3ed935aa
credential_store.mm 17.8 KB