• Alex Moshchuk's avatar
    Revert "Implement a11y support for permission chip UI" · 3ee62d38
    Alex Moshchuk authored
    This reverts commit a28187dc.
    
    Reason for revert: After this change, PermissionPromptBubbleViewBrowserTest.AlertAccessibleEvent is failing consistently on some Mac try bots: 
     https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/58202
    https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/40075
    
    Sample failure:
    ../../chrome/browser/ui/views/permission_bubble/permission_prompt_bubble_view_browsertest.cc:199: Failure
    Expected equality of these values:
      2
      counter.GetCount(ax::mojom::Event::kAlert)
        Which is: 1
    
    
    Original change's description:
    > Implement a11y support for permission chip UI
    >
    > Announce to screenreaders that a permission has requested if chip UI is
    > used. For prompt UI, the bubble is shown and it takes over the focus.
    > Chip UI is less intrusive so it must be explicitly annouced for screen
    > reader users. To avoid users not hearing the announcement, it would be
    > reannouced after 2 minutes.
    >
    > Chip UI is now one of the panes (users can cycle through panes with F6). This way users can easily access it with keyboard which is very important for screenreader users.
    >
    > Also to make sure that users don't miss pending permission request, added message about having pending permission request to tab announcement.
    >
    > Bug: 1150836
    >
    > Change-Id: I7118abcf0bed9702cf17d15a9bb59f9a1d8783b6
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578843
    > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
    > Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#836198}
    
    TBR=bsep@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,olesiamarukhno@google.com
    
    Change-Id: I3f11f1b4de624199c5ba2a4c4f4c7c327a7cde8a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1150836
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586966Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
    Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#836276}
    3ee62d38
permission_chip.cc 10.2 KB