• Etienne Bergeron's avatar
    Revert "Move ISpVoice instance to a worker thread" · 3f00e196
    Etienne Bergeron authored
    This reverts commit b642822f.
    
    This CL is causing a shutdown crash.
      https://bugs.chromium.org/p/chromium/issues/detail?id=1142247
    
    It will be merged back into next canary with the fix.
    
    
    Original change's description:
    > Move ISpVoice instance to a worker thread
    >
    > This CL is moving the speech synthesizer code to a worker thread.
    >
    > The TtsPlatformImpl is using an ISpVoice COM interface to perform
    > text-to-speech actions. The instance was living on the UI Main
    > Thread which was using STA Apartment.
    >
    > This CL is splitting the logic in two parts. The first part is the
    > control logic which stay on the UI Thread. The second part is the
    > synthesizer logic which is running on a worker thread.
    >
    > Bug: 869399, 1133813
    > Change-Id: I8f8d939950cc39637f87d101ed362123a51e985e
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462341
    > Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
    > Reviewed-by: François Doray <fdoray@chromium.org>
    > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#820340}
    
    TBR=dmazzoni@chromium.org,fdoray@chromium.org,etienneb@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 869399
    Bug: 1133813
    Change-Id: I6249ad2d5d7938e8aa960bbd8d0798f7396513ff
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499602Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
    Commit-Queue: Etienne Bergeron <etienneb@google.com>
    Cr-Commit-Position: refs/heads/master@{#820887}
    3f00e196
tts_win.cc 11.8 KB