• Will Harris's avatar
    Fix -Wshorten-64-to-32 warnings in ui/events. · 3f6b636c
    Will Harris authored
    ../../ui/events/keycodes/dom/dom_keyboard_layout_map_win.cc(58,32):  warning: implicit conversion loses integer precision: 'std::vector<HKL__ *, std::allocator<HKL__ *> >::size_type' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
          keyboard_layout_handles_.size(), keyboard_layout_handles_.data());
          ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
    ../../ui/events/keycodes/dom/dom_keyboard_layout_map_win.cc(75,35):  warning: implicit conversion loses integer precision: 'std::vector<HKL__ *, std::allocator<HKL__ *> >::size_type' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
      return keyboard_layout_handles_.size();
      ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
    
    ../../ui/events/keycodes/dom/dom_keyboard_layout_map_base.cc(32,44):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
            keyboard_layout_manager->GetLayout(i);
                                     ~~~~~~~~~ ^
    ../../ui/events/keycodes/dom/dom_keyboard_layout_map_base.cc(33,20):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
        PopulateLayout(i, dom_keyboard_layout);
        ~~~~~~~~~~~~~~ ^
    
    ../../ui/events/test/event_generator.cc(673,51):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32]
          (ui::EventTimeForNow() - base::TimeTicks()).InMicroseconds();
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
    
    ../../ui/events/win/events_win_utils.cc(257,36):  warning: implicit conversion loses integer precision: 'const LPARAM' (aka 'const long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32]
        return gfx::Point(native_event.lParam);
               ~~~        ~~~~~~~~~~~~~^~~~~~
    
    ../../ui/events/event_utils.cc(112,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                      delta.InMicroseconds(), 1, 1000000, 50);
                                      ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
            name, sample, min, max, bucket_count,                                  \
            ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
            name, Add(sample),                                                     \
                  ~~~ ^~~~~~
    ../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                              histogram_add_method_invocation,                     \
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
        histogram_pointer->histogram_add_method_invocation;                        \
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../ui/events/event_utils.cc(116,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                      delta.InMicroseconds(), 1, 1000000, 50);
                                      ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
            name, sample, min, max, bucket_count,                                  \
            ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
            name, Add(sample),                                                     \
                  ~~~ ^~~~~~
    ../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                              histogram_add_method_invocation,                     \
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
        histogram_pointer->histogram_add_method_invocation;                        \
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../ui/events/event_utils.cc(120,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                      delta.InMicroseconds(), 1, 1000000, 50);
                                      ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
            name, sample, min, max, bucket_count,                                  \
            ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
            name, Add(sample),                                                     \
                  ~~~ ^~~~~~
    ../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                              histogram_add_method_invocation,                     \
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
        histogram_pointer->histogram_add_method_invocation;                        \
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../ui/events/event_utils.cc(124,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                      delta.InMicroseconds(), 1, 1000000, 50);
                                      ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
            name, sample, min, max, bucket_count,                                  \
            ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
            name, Add(sample),                                                     \
                  ~~~ ^~~~~~
    ../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                              histogram_add_method_invocation,                     \
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
        histogram_pointer->histogram_add_method_invocation;                        \
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    4 warnings generated.
    [22971/48339] CXX obj/ui/events/events/keyboard_hook_win.obj
    ../../ui/events/win/keyboard_hook_win.cc(117,25):  warning: implicit conversion loses integer precision: 'WPARAM' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32]
        MSG msg = {nullptr, w_param, ll_hooks->vkCode,
                  ~         ^~~~~~~
    
    ../../ui/events/event.cc(1137,47):  warning: implicit conversion loses integer precision: 'const WPARAM' (aka 'const unsigned long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
        key_ = DomKey::FromCharacter(native_event.wParam);
               ~~~~~~                ~~~~~~~~~~~~~^~~~~~
    
    BUG=879657
    
    Change-Id: If41fb68b2e054ff4f429396e78048d48f71a3e38
    Reviewed-on: https://chromium-review.googlesource.com/1214682Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
    Commit-Queue: Will Harris <wfh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#590185}
    3f6b636c
keyboard_hook_win.cc 5.38 KB