-
Sami Kyöstilä authored
This reverts commit 3bdb9041. Reason for revert: Seems to be causing crashes on Pixel 2: https://ci.chromium.org/ui/p/chrome/builders/ci/android-pixel2-perf/13030/overview Original change's description: > Accessibility Image Descriptions Port, Part VII - Incognito > > This CL is the seventh part of an effort to port the existing Desktop > feature to Android. This feature enables a user to send an image to > Google to process to generate a descriptive alt text if a website > does not provide one. > > Design Doc: go/2020-q1-android-image-descriptions > Slide Deck: go/clank-imageDescriptions > Launch Bug: 1057168 > > Original Desktop Design Doc for reference: > go/chrome-a11y-annotations-design > > This is a conservative approach, we use a separate set of profile > Prefs for this feature rather than syncing with the Desktop Prefs. > This can be updated in time as needed. > > ---------- > > This CL adds the following: > > - Syncs Regular and Incognito behavior as per new reqs > - Corrects unit tests for above > - Adds an AXMode observer to watch for screen readers being enabled > > ---------- > > > AX-Relnotes: Android accessibility image descriptions behavior in incognito tabs will now match the regular tabs behavior for that profile. > Bug: 1057169 > Change-Id: I27b6cb1c3da4cae441a6519815f7835049827452 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585587 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Mark Schillaci <mschillaci@google.com> > Commit-Queue: Mark Schillaci <mschillaci@google.com> > Cr-Commit-Position: refs/heads/master@{#836174} TBR=dmazzoni@chromium.org,twellington@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,mschillaci@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1057169 Change-Id: Ib28af4808090c432219137456451aa1b9ce6c230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589933Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#836625}
3ffda819