• Bruce Dawson's avatar
    Revert "Track progress through View destructor" · 3fff88ce
    Bruce Dawson authored
    This reverts commit 24e521c6.
    
    Reason for revert: bug has been found and fixed
    
    Original change's description:
    > Track progress through View destructor
    >
    > The View destructor ends up in an impossible state which means that
    > execution must have branched to the middle of it, but it is not clear
    > how this could happen. This change adds an array of line numbers that is
    > filled in as the destructor runs to leave us some bread crumbs. It also
    > records the vtable of the about-to-be-deleted child object so that we
    > can investigate if this is a type-related bug.
    >
    > Bug: 1152152
    > Change-Id: I386507974a8b6ccd1914e0ec62151456411f0c19
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572793
    > Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    > Reviewed-by: Robert Liao <robliao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#833875}
    
    TBR=robliao@chromium.org,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1152152
    Change-Id: I62871ab84d1a219c9eed67bc2ce3d0b4ceed44c8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580545Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
    Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
    Commit-Queue: Robert Liao <robliao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#834999}
    3fff88ce
view.cc 94.8 KB