• Benoit Lize's avatar
    base/allocator: Report the size of mapped PageAllocator space when crashing. · 402cee70
    Benoit Lize authored
    PartitionAllocator can occupy a lot of address space, as freed pages for
    normal buckets are never unmapped, and these are not shared across
    buckets. This is a known issue, tracked in the linked bug.
    
    However the reporting currently in place only looks at a single
    partition when reporting that an OOM is likely due to too many mapped
    pages. It does not look at all PageAllocator allocations. This commit
    adds a crash key reporting the total amount of mapped PageAllocator
    pages to crash reports, to allow distinguishing between "true" OOM and
    address space exhaustion.
    
    For instance, on Windows 32, an address space exhaustion crash would
    happen with a reasonable committed set, remaining system commit limit,
    and a large amount of mapped pages. All these data points are available
    in crash reports, except for the last one, which this commit adds.
    
    Bug: 421387
    Change-Id: If3eac64489b61297cb5da6da328cfc70fecc4c8c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264438Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
    Commit-Queue: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#782459}
    402cee70
BUILD.gn 8.69 KB