• Andy Paicu's avatar
    Revert "Reland "[base] Introduce base::CheckedContiguousRange"" · 409610fc
    Andy Paicu authored
    This reverts commit 84fcf8bb.
    
    Reason for revert: This breaks the win-asan build (base_unittests)
    
    First failing build: https://ci.chromium.org/p/chromium/builders/ci/win-asan/8314
    
    Original change's description:
    > Reland "[base] Introduce base::CheckedContiguousRange"
    > 
    > This is a reland of 83ced150
    > 
    > Original change's description:
    > > [base] Introduce base::CheckedContiguousRange
    > > 
    > > This change introduces base::CheckedContiguousRange, which similarly to
    > > base::span is a light-weight wrapper around a contiguous container
    > > performing bound CHECKs.
    > > 
    > > However, in contrast to base::span this class keeps a pointer to the
    > > underlying container, and thus is able to respond to changes to data()
    > > and size(), which base::span can't do.
    > > 
    > > Furthermore, this change provides a constexpr overload of base::data()
    > > for std::array and fixes a bug in CheckedContiguousIterator::operator-=.
    > > 
    > > Bug: 990059
    > > 
    > > Change-Id: I3fef91c7ef7874bf495ac2ab6dbaf3a8b02dab35
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893858
    > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    > > Reviewed-by: Chris Palmer <palmer@chromium.org>
    > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#712120}
    > 
    > Bug: 990059
    > Change-Id: If7cfd16ca526930643e9fac7567f58ba9ef60b1f
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893069
    > Reviewed-by: Chris Palmer <palmer@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#712493}
    
    TBR=palmer@chromium.org,dcheng@chromium.org,jdoerrie@chromium.org
    
    Change-Id: I1ff98725f82a957067cd02ab82d3f96b2fdd3622
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 990059
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899777Reviewed-by: default avatarAndy Paicu <andypaicu@chromium.org>
    Commit-Queue: Andy Paicu <andypaicu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#712572}
    409610fc
span_unittest.cc 46.4 KB