GitLab

Due to a quirk in VC++ it is easy to accidentally prevent a const global
array from being placed in the read-only data segment. This change
removes some should-be-harmless 'const' keywords to work around this
quirk and move ~2,500 bytes to the .rdata (read-only) data segment
across chrome.dll and chrome_child.dll. The arrays affected include
kMagicNumbers, kExtraMagicNumbers, kSniffableTags, kOfficeExtensionTypes,
and a few others.

VC++ bug is filed here:
https://connect.microsoft.com/VisualStudio/feedback/details/3117602

Other instances of this quirk are also being worked around.

BUG=677351

Review-Url: https://codereview.chromium.org/2607993002
Cr-Commit-Position: refs/heads/master@{#441007}