-
Justin Cohen authored
This reverts commit 0ab91ac7. Reason for revert: Failures starting in: https://ci.chromium.org/p/chromium/builders/ci/ios14-sdk-simulator/2281 * ClipboardRecentContentIOSTest.AddingNonStringRemovesCachedString * ClipboardRecentContentIOSTest.PasteboardURLObsolescence * ClipboardRecentContentIOSTest.SchemeFiltering * ClipboardRecentContentIOSTest.SuppressedPasteboardImage * ClipboardRecentContentIOSTest.SuppressedPasteboardText https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8872067354517054672/+/steps/components_unittests_iPhone_6s_14.0_on_Mac-10.15/0/stdout Original change's description: > Fix iOS Omnibox Clipboard Suggestions to not immediately read clipboard > > The basic idea here is to factor out the match creation methods. On iOS > 14, if the clipboard contains content, we create a blank match of the > correct type (one without any destination_url). Then, when the match > is selected for opening, we can ask the clipboard_provider for a new > match using the proper text, and open that one instead. > > For other platforms, we can keep using the old method, where we access > the clipboard immediately and construct the destination_url at match > creation time. iOS 14 also uses this behavior if there is cached > clipboard content. > > Bug: 1105869 > Change-Id: I70d26f4bcc485e4dc9073db2257161355adc8a40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346290 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Reviewed-by: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797671} TBR=jdonnelly@chromium.org,tedchoc@chromium.org,manukh@chromium.org,rkgibson@google.com Change-Id: I170940bf76f9e60ab0eb9d15e549fd4a62de45d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1105869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354524Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797803}
40f1bad5
