• Antoine Labour's avatar
    Fix texture_target_exception_list for unit tests · 41093c0d
    Antoine Labour authored
    Previously, InProcessGpuThreadHolder initialized
    texture_target_exception_list according to the production expectations,
    in particular assuming native GMB types when available. However all unit
    tests use viz::TestGpuMemoryBufferManager (if any GMBManager at all)
    which only produces shared memory GMBs. This means the wrong target will
    be used for those. It's mostly harmless on Mac
    (GL_TEXTURE_RECTANGLE_ARB) but no so much on other platforms
    (GL_TEXTURE_EXTERNAL_OES which doesn't allow glTex*Image*).
    
    Instead, leave texture_target_exception_list empty, individual tests can
    initialize it if they need (e.g. if they use a GpuMemoryBufferFactory).
    
    Bug: 897214
    Change-Id: I55984ef49797fa97f00e2bda35b60a4e6ba734bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1322610
    Commit-Queue: Antoine Labour <piman@chromium.org>
    Reviewed-by: default avatarkylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606195}
    41093c0d
raster_in_process_context_tests.cc 8.41 KB