• Dana Fried's avatar
    Revert "Keyboard accessibility for extensions menu." · 4123e9d8
    Dana Fried authored
    This reverts commit 91b01545.
    
    Reason for revert: called wrong method, enabling arrow key traversal globally instead of locally
    
    Bug: 1142343
    
    Original change's description:
    > Keyboard accessibility for extensions menu.
    >
    > This change switches the extensions menu to enable focus traversal at
    > the focus manager level, allowing both right/left and up/down key
    > traversal.
    >
    > It also removes
    > BubbleDialogDelegateView::EnableUpDownKeyboardAccelerators() - which is
    > only used in one other place - in favor of
    > FocusManager::set_arrow_key_traversal_enabled(), which also supports
    > left/right arrows and pre-exists the bubble dialog method.
    >
    > These changes mean that when the scroll pane is active in either dialog,
    > up and down will scroll the pane but left and right arrow keys will
    > still allow the user to traverse the dialog (at least on Windows and
    > Linux; on Mac, up/down may still work within the pane).
    >
    > Bug: 1140632
    > Change-Id: I8ea5bc79e9b9ed2595e9503be1221843c50a7b3e
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487904
    > Reviewed-by: Peter Boström <pbos@chromium.org>
    > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    > Commit-Queue: Dana Fried <dfried@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#820456}
    
    TBR=dmazzoni@chromium.org,sky@chromium.org,pbos@chromium.org,dfried@chromium.org,corising@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1140632
    Change-Id: I4c1d30602c132bdd3f06ab95f0215e5909373ff9
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501074
    Commit-Queue: Dana Fried <dfried@chromium.org>
    Reviewed-by: default avatarDana Fried <dfried@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#821156}
    4123e9d8
extensions_menu_view.cc 19.1 KB