GitLab

This reverts commit eb95adf5.

Reason for revert: Flaky test fixed.

Original change's description:
> Revert "Reland "Persist Reader Mode theme and font family settings on desktop.""
> 
> This reverts commit d1173dbd.
> 
> Reason for revert: DomDistillerViewerSourceBrowserTest.UISetsPrefs flaky
> 
> Original change's description:
> > Reland "Persist Reader Mode theme and font family settings on desktop."
> > 
> > This reverts commit 23979013, which
> > reverted an earlier implementation of this CL in commit
> > a18fd063 due to
> > https://crbug.com/1065341.
> > 
> > The main functional difference between this and the original version is
> > where the JavaScript code calls the pref-storing functions. They were
> > previously called inside useTheme() and useFontFamily() instead of the
> > UI callbacks. Changes to the synced prefs result in a series of
> > observers being notified, which ultimately led to the useTheme() and
> > useFontFamily() methods being called again, potentially leading to an
> > infinite loop and the behavior seen in the bug.
> > 
> > The updateThemeSelection() method from the original CL was excluded in
> > this reimplementation because it was unintentionally never called in the
> > original CL. Omitting it helps reduce the scope of the CL and highlight
> > the important changes.
> > 
> > Bug: 1016615, 1065341
> > Change-Id: Ifd0e71027afd196267419ed81f7bdc0d78978a98
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152901
> > Reviewed-by: Emily Stark <estark@chromium.org>
> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Commit-Queue: Aran Gilman <gilmanmh@google.com>
> > Cr-Commit-Position: refs/heads/master@{#762524}
> 
> TBR=dmazzoni@chromium.org,estark@chromium.org,wychen@chromium.org,gilmanmh@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1016615, 1065341, 1075439
> Change-Id: I222e95940848b68fa8158fd64aaca76048ed96db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167751
> Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
> Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#762756}

TBR=dmazzoni@chromium.org,estark@chromium.org,wychen@chromium.org,hendrich@chromium.org,gilmanmh@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1016615, 1065341, 1075439
Change-Id: Id1033620710d17d45c2df85a126b44a1f226e8b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170422Reviewed-by: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#768954}