• Kazuki Takise's avatar
    Show the auto-hide shelf if there is a single PIP window · 414a2324
    Kazuki Takise authored
    This CL reverts https://crrev.com/c/1529500.
    
    The reason why we hid the auto-hide shelf at the time is that we
    didn't apply the collision detection logic to the PIP initial
    bounds and the auto-hide shelf could overlap with PIP. Now that we
    apply collision detection to the initial bounds, we can now revert
    this CL.
    
    Currently there are a few issues with PIP if the auto-hide shelf
    gets hidden when there's a single PIP window.
    - When you trigger PIP via minimize, the original window gets
      minimized first and the auto-hide shelf becomes shown, but soon
      after PIP shows up and the shelf becomes hidden again, which
      looks a bit weird.
    - When PIP gets shown, the auto-hide shelf is still visible and
      then it gets hidden, but the PIP window doesn't move to the
      bottom as at this point the gravity is "to the right".
    
    BUG=b:149889866
    TEST=Manually confirmed the PIP interacts well with the auto-hide
    TEST=shelf.
    
    Change-Id: I643487b53b23931bdabd816a30c6337741d15fc4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065256Reviewed-by: default avatarEliot Courtney <edcourtney@chromium.org>
    Reviewed-by: default avatarStefan Kuhne <skuhne@chromium.org>
    Commit-Queue: Kazuki Takise <takise@chromium.org>
    Auto-Submit: Kazuki Takise <takise@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#743391}
    414a2324
shelf_layout_manager_unittest.cc 153 KB