• jinsukkim's avatar
    Add a test for RenderWidgetHostConnector · 414a9028
    jinsukkim authored
    A new test got added to render_widget_host_connector_browsertest.cc
    which ensures RWHVA gets connected to objects inheriting
    RenderWidgetHostConnector regardless of the order in which they
    are created. Previously this had a bug resulting in RWHVA not
    connected ImeAdapter if RWHVA was created first, hence keeping
    soft keyboard from showing up.
    
    Also removed |WebContentsObserver::RenderViewReady()| override. It was
    overridden to initialize rwvha in the connector after creation. But it
    only covers the following cases:
    
    - connector created -> rwhva created -> RenderViewReady invoked
    - rwhva created -> connector created -> RenderViewReady invoked
    
    Can't cover the following case:
     - rwhva created -> RenderViewReady invoked -> connector created
    
    Now Initialize() covers them all, the method became redundant.
    
    BUG=713924
    
    Review-Url: https://codereview.chromium.org/2840443002
    Cr-Commit-Position: refs/heads/master@{#466877}
    414a9028
render_widget_host_connector.cc 4.78 KB