GitLab

ServiceWorkerContextWrapper::StartWorkerForScope searches for
registration with active or installing worker through
DidFindRegistrationForFindImpl. For the case where there is an
installingworker, DidFindRegistrationForFindImpl can see a
registration.installing_version(), but the version can be gone by
the time it PostTask-s to FoundRegistrationForStartWorker
if the service worker script rejected the 'install' event.

This CL removes the DCHECK that incorrectly assumes either active
or installing version *must* be present
in FoundRegistrationForStartWorker. The DCHECK failure is evident
in the flaky extension test failure:
ServiceWorkerBasedBackgroundTest.WorkerStartFailureClearsPendingTasks.
The CL also enables the mentioned test.

Bug: 1063476
Change-Id: I12dd3b5f2155bc8b8677f9734443832c1a96fe61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119208Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753555}