• Alexei Svitkine's avatar
    Add a CHECK failure for when the resource bundle loading fails. · 41dc15f1
    Alexei Svitkine authored
    This matches the CHECK in chrome/app/chrome_main_delegate.cc
    with the same message.
    
    These errors are not recoverable, and currently result in a CHECK
    being hit later in VariationsService::EnsureLocaleEquals(), which
    is trying to guard for locale mismatch issues.
    
    Also expands header comments to mention the empty string return
    value being the failure case.
    
    See ResourceBundle::LoadLocaleResources() implementation for the
    failure details (i.e. if empty string was returned, we either
    didn't load the pack file at all, or got an error loading it).
    
    Bug: 1022934
    Change-Id: I4cc670cf669ed824c3b2073586941931fd38e364
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141010Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
    Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#758991}
    41dc15f1
chrome_resource_bundle_helper.cc 5.13 KB