GitLab

Add a new browser test for checking that a maximized window responds
correctly to the virtual keyboard.

Had to change how WaitUntilShown and WaitUntilHidden worked.
|WaitUntilShown| used to just wait for the window visibility to change,
but KeyboardController sets the window visiblity at the beginning of
the show animation. So |WaitUntilShown| was more like
"WaitUntilStartingToShow".

This was a problem because overscrolling occurred after the animation
finishes, so the tests have to wait for animations to finish.

We changed it to wait instead of the keyboard visiblity as dictated
by the KeyboardController. This visiblity gets updated when the
show animation finishes. Unfortunately this is not true for the
hide animation, but it doesn't really affect our tests since
overscrolling also happens at the beginning of the hide animation.

Also see crbug.com/866332 for more about the different types of
"visibility".

Bug: 849995
Change-Id: I9c9dbee9423b63db3df58814e59eb41a9cab2d90
Reviewed-on: https://chromium-review.googlesource.com/1233314
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593105}