• Yu Han's avatar
    Reland "[Controls Refresh] Update controls styles for dark mode" · 428cc3d1
    Yu Han authored
    This is a reland of 0397ac4e
    
    The original CL was reverted because it caused two tests failures on
    the win7 platform [1]. I think what happened I manually corrected the
    rebaseline tool's merging of some of the expected files. These led to
    not removing the expected files for these two tests on win7 platform.
    And since CQ's win7 builder doesn't auto run, it CL passed where it
    should have failed.
    
    I've since removed these two invalid expected files from win7 platform.
    In addition, I removed fuchsia/virtual/dark-color-scheme/fast/forms/color-scheme/color/color-picker-appearance-expected.png
    because its incorrect and I don't see the virtual suite tested on
    fuchsia. Ran CQ on all platforms and they passed.
    
    [1] https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/b8866243899672370144
    
    Original change's description:
    > [Controls Refresh] Update controls styles for dark mode
    >
    > This CL updates the dark mode styles for the following controls:
    > 1. <meter> -  border color.
    > 2. multi-select - foreground text color.
    > 3. Button: Dark mode button design has no border and has unique fill
    >    color. Thus, a specific set of color enums is created for only
    >    buttons. Button's border color is styled to match its fill color
    >    in order to give the appearance of no borders and keep its
    >    dimensions unchanged. This impacts: button, file, and color
    >    controls.
    >
    >
    > Bug: 1107290, 1099624
    > Change-Id: I141c199f93acac2b950b8af7195e863f811c2f4c
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469357
    > Commit-Queue: Yu Han <yuzhehan@google.com>
    > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    > Reviewed-by: Mason Freed <masonfreed@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#818119}
    
    Bug: 1107290
    Bug: 1099624
    Change-Id: I3097043a036da08dc201e0ce78ecc2ed1c94a1a7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485039Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
    Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Yu Han <yuzhehan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#819549}
    428cc3d1
native_theme_base.h 10.8 KB