GitLab

ServerConnectionManager (and its implementations, plus some related
helper classes) returned an HttpResponse as an output parameter.
Output parameters are generally discouraged, and here in particular,
they made the logic hard to follow since the whole thing went through
many layers.

Before this CL, the methods in question returned a bool that roughly
meant "success", but it was inconsistent (in some layers, an HTTP error
would be counted as success, in others as failure). Now, they return
the HttpResponse instead. Clients now query the "success" they're
interested in from the HttpResponse.

Bug: 951350
Change-Id: Idd7867246506caf069287e4dc34c8b59a1da59fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465910
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816613}