• Jun Mukai's avatar
    Do not use the accelerometer device file when it's failed to read · 42f6f938
    Jun Mukai authored
    On some system / device configuration, the accelerometer device
    file exists but can't be read by the browser process. When this
    happens, it generates error log repeatedly, which is not great.
    
    This CL tries to address this issue in a way. On initializing
    accelerometer configuration, it tries to read the device file
    at that time, and when it fails to read, it just stops the
    initialization and reports an error message. This happens once,
    and does not generate repeated logs.
    
    Also, when an error happens, now it can obtain the errno and
    print it as a part of the log, so it would be more understandable
    why it fails. On my case, it is just permission denied, for some
    reasons.
    
    Bug: 1134527
    Test: manually with nautilus device in the lab
    Change-Id: Ib9823631a70fc54d3e3abc35067aff56a7d7ee50
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454840Reviewed-by: default avatarMin Chen <minch@chromium.org>
    Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#814780}
    42f6f938
accelerometer_reader.cc 27.5 KB