• Sunny Sachanandani's avatar
    Reland "gpu: Sync to primary monitor's vblank (windows)" · 432ffabd
    Sunny Sachanandani authored
    This reverts commit d332af51.
    
    Fixed crash due to missing member var initialization.
    
    TEST=ran failing gl_unittests locally
    
    Original change's description:
    > Revert "gpu: Sync to primary monitor's vblank (windows)"
    >
    > This reverts commit bd0cae50.
    >
    > Reason for revert: Cause failures in DirectCompositionSurfaceTest.*
    > Builder: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Debug%20%28NVIDIA%29?limit=200
    > First build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Debug%20%28NVIDIA%29/22377?blamelist=1#overview-tab
    >
    > Crash example:
    > ...snip...
    >
    > Original change's description:
    > > gpu: Sync to primary monitor's vblank (windows)
    > >
    > > DWM composition is limited to primary monitor's refresh rate.  Prior to
    > > GPU vsync we would use DWM composition rate to drive begin frames.
    > >
    > > With GPU vsync we started using per monitor vblank to limit begin frames
    > > in case primary monitor had higher refresh rate, but this might be
    > > causing draw duration and omnibar latency regressions.  MS platform team
    > > also suggested syncing to primary monitor only.  In any case the correct
    > > approach would be to further limit begin frames based on event queries
    > > from 2 frames back.
    > >
    > > This CL makes the GPU vsync begin frames sync to primary monitor, and
    > > also makes the vsync thread a singleton since it doesn't have per-window
    > > state any more.
    > >
    > > Bug: 953970
    > > Change-Id: Id3d3f043cb847172b1d6ba4bd38b087ceb2d8631
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711215
    > > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    > > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#679832}
    >
    > TBR=zmo@chromium.org,sunnyps@chromium.org
    >
    > Change-Id: If4a762325952dd33283bf41a13321e759de51025
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 953970
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713510
    > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
    > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#679915}
    
    TBR=zmo@chromium.org,sunnyps@chromium.org,kolos@chromium.org
    
    Change-Id: I743026c218932916aba9d9c7722d8343e9fdbdd9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 953970
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716211
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Reviewed-by: default avatarSunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#680276}
    432ffabd
direct_composition_child_surface_win.h 4.1 KB