GitLab

This change stops browser_tests from creating "Cached Theme.pak" files
in the Chromium source tree. These generated files frequently cause
confusion when they are accidentally added to CLs, and linger in the
Chromium repo.

Background: "Cached Theme.pak" is a preprocessed version of a Chrome
theme. It is created in the theme's directory when a theme is loaded,
to speed up future loading.

The chrome/test/data directory contains seed data for tests, including
some sample themes. When browser tests load these themes, the "Cached
Theme" files are created in the chrome/test/data directory in the
source tree.

To prevent this, this change adds method
ThemeService::DisableThemePackForTesting() for browser tests to call
before loading themes from chrome/test/data.

Bug: 852623
Change-Id: Idc0ccfee80b9e9c26cc0f4d5467dadf35f8a85e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403588Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#807957}