• Alice Boxhall's avatar
    Revert "X11Window: Avoid size hack for tests" · 43dc520f
    Alice Boxhall authored
    This reverts commit da320a9f.
    
    Reason for revert: Unfortunately this seems to be causing a CI failure: 
    https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898137098615237856/+/steps/aura_unittests/0/logs/Deterministic_failure:_WindowTreeHostTest.DPIWindowSize__status_FAILURE_/0
    
    Original change's description:
    > X11Window: Avoid size hack for tests
    > 
    > The default configuration of TestScreen is to create one display and one
    > WindowTreeHost with the same size.
    > 
    > X11 is now incompatible with this requirement as of b14e13fd ("Reland
    > "X11 and Ozone: DWTHPlatform handles Show/Hide/Max/Restore/Full"").
    > 
    > Several aura tests are only passing currently due to another bug in
    > DisplayList::UpdateDisplay, which prevents X11Window from
    > seeing the current display size and enforcing the constraint.
    > 
    > Other tests only work because TestScreen resizes the display to match
    > the WindowTreeHost /after/ X11Window deletes the last row and column.
    > i.e., X11Window tries to adjust the size to not match the display,
    > and then TestScreen re-adjusts the display to match the window. This
    > behavior is not convergent and causes small changes in initialization
    > order to affect the dimensions of test windows.
    > 
    > This hack should likely be removed altogether and the bug it's addressing
    > fixed another way, but for now disable it in the test harness because it
    > is blocking other changes such as a fix for the UpdateDisplay bug noted
    > above.
    > 
    > Bug: 1019015
    > 
    > Change-Id: I79e830b9c35df3df29dc8af50ac424076682d180
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889294
    > Commit-Queue: Michael Spang <spang@chromium.org>
    > Reviewed-by: Michael Spang <spang@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#710955}
    
    TBR=sky@chromium.org,spang@chromium.org,thomasanderson@chromium.org,msisov@igalia.com
    
    Change-Id: I1177d258e4957dc1f216e18c6df95067f7cbb0ed
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1019015
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890458Reviewed-by: default avatarAlice Boxhall <aboxhall@chromium.org>
    Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#711094}
    43dc520f
window_tree_host_unittest.cc 7.41 KB