• Joey Scarr's avatar
    Fix quoting when writing defines on Windows. · 44054a1e
    Joey Scarr authored
    For the following string-valued define:
     defines = [ "CR_CLANG_REVISION=\"$clang_revision\"" ]
    this was outputting the following on Windows:
     -D"CR_CLANG_REVISION=\"332838-1\""
    The Windows shell can't handle the extra quotes, and so the following
    macro was being written:
     #define "CR_CLANG_REVISION "332838-1""
    This change moves the first quote to before the -D, allowing Windows to
    correctly handle the define parameter.
    
    R=brettw@chromium.org
    
    Bug: 396230
    Change-Id: I4f6f70acf775577ff9b3077eba9ebf7f8d002da1
    Reviewed-on: https://chromium-review.googlesource.com/1071274Reviewed-by: default avatarBrett Wilson <brettw@chromium.org>
    Commit-Queue: Joey Scarr <jsca@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#565117}
    44054a1e
ninja_binary_target_writer_unittest.cc 40.2 KB