• David Roger's avatar
    [signin] Split multilogin code out of GaiaCookieManagerService · 44066d85
    David Roger authored
    This CL is a code cleanup of the multilogin code.
    The code is split in two new classes, and should be a lot clearer.
    
    The retry logic has been revisited, and in particular a potential
    infinite loop was removed:
    in the previous code, a "invalid tokens" response was always retried.
    The code was relying on Android (GMSCore) to invalidate and evict the access
    token, so that the same token is not retried endlessly.
    However, in case of a GMSCore bug, an infinite loop may happen.
    We don't have a proof that this was happening, but as we have seen a large
    number of errors coming from a few devices, this CL adds protection against
    this and only retries once.
    
    Change-Id: I097b6104f12f6abb65b1a30f75d753cef6610c17
    Bug: 957536
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572131
    Commit-Queue: David Roger <droger@chromium.org>
    Reviewed-by: default avatarMihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#654826}
    44066d85
BUILD.gn 9.8 KB