• Samuel Huang's avatar
    [SuperSize] Round padding values in .sizediff. · 44c64471
    Samuel Huang authored
    When creating symbol diffs, mismatches in alias counts and summing
    fractional padding PSS values can lead to DiffSymbols with non-integer
    padding values. However, numeric values in .sizediff files should be
    integers. This CL implements a simple fix: Round paddings to integer
    when creating DiffSymbols. The resulting inaccuracy would be in the
    order of bytes, and therefore negligible.
    
    Bug: 1132394
    Change-Id: Iba9acb0a94de6890aec01ac6c9ee450fb9d69dd6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432668
    Commit-Queue: Samuel Huang <huangs@chromium.org>
    Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#810827}
    44c64471
diff.py 7.68 KB