• Evan Stade's avatar
    Tweaks to app modal dialog shutdown. · 44d63178
    Evan Stade authored
    Make sure that an invalidated dialog doesn't call
    AppModalDialogQueue::ShowNextDialog() during shutdown. This could
    potentially cause issues as it causes ShowNextDialog to be reentrant,
    which doesn't seem intentional.
    
    Also remove an unnecessary check: the active dialog is not in the dialog
    queue so we don't need to check the queue against the active dialog when
    hiding a batch of dialogs.
    
    Bug: 1060986
    Change-Id: I962a5cf14c3f5b67d287de61464b604dbe96aaf7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295822
    Commit-Queue: Evan Stade <estade@chromium.org>
    Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#789242}
    44d63178
app_modal_dialog_controller.h 5.61 KB