• Jiewei Qian's avatar
    Revert "capture_mode: Recording service lifetime and APIs" · 45b78e7b
    Jiewei Qian authored
    This reverts commit 38feda4d.
    
    Reason for revert: Observed test failure on Linux ChromiumOS MSAN build.
    
    use-of-uninitialized-value during CaptureModeController::Start()
    
    This CL makes significant changes to CaptureModeController.
    
    See https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21350
    
    Original change's description:
    > capture_mode: Recording service lifetime and APIs
    >
    > This is a follow-up CL to handle requests made on the recording
    > service CL (https://crrev.com/c/2404145):
    > - The Record*() APIs of the service should provide the needed client,
    >   video capturer, and audio stream factory, instead of exposing APIs
    >   in the client so that anyone can bind to those capturers.
    > - The service is launched to handle video recording, and terminated
    >   once recording ends, and all the chunks have been sent.
    > - A GPU crash is handled by ending the recording.
    >
    > BUG=1126586, 1147989, 1143411
    > TEST=Manually, existing tests.
    >
    > Change-Id: I235cb1f9ee81dbbc42e21d0a222d32bcafa7a0fd
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536030
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: James Cook <jamescook@chromium.org>
    > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#828574}
    
    TBR=jamescook@chromium.org,dcheng@chromium.org,afakhry@chromium.org
    
    Change-Id: I80c5b69f89fa4eb32d3cbd065729d314d076ae4d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1126586
    Bug: 1147989
    Bug: 1143411
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546348
    Commit-Queue: Jiewei Qian  <qjw@chromium.org>
    Reviewed-by: default avatarJiewei Qian  <qjw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#828626}
    45b78e7b
chrome_capture_mode_delegate.cc 5.34 KB