• Tommy Steimel's avatar
    Revert "Reland "Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource"" · 46010c3e
    Tommy Steimel authored
    This reverts commit 02979f89.
    
    Reason for revert: Causing failures on linux-xenial-rel bot:
    
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/6075
    
    Original change's description:
    > Reland "Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource"
    > 
    > This is a reland of 7c6d18ba
    > 
    > Original change's description:
    > > Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource
    > >
    > > This CL is strictly a refactor that switches the Ads PLMO to count frame
    > > data using ResourceDataUseUpdate instead of OnLoadedResource. This will
    > > allow us to include incomplete resources and header bytes in future
    > > per-frame metrics. This will not change behavior of existing histograms
    > > at all.
    > >
    > > Bug: 878393
    > > Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1372428
    > > Commit-Queue: John Delaney <johnidel@chromium.org>
    > > Reviewed-by: Robert Sesek <rsesek@chromium.org>
    > > Reviewed-by: Josh Karlin <jkarlin@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#619436}
    > 
    > TBR=rsesek@chromium.org
    > 
    > Bug: 878393
    > Change-Id: I9c8760497d2a5110f4bae31d633d82a405ed812a
    > Reviewed-on: https://chromium-review.googlesource.com/c/1393530
    > Commit-Queue: John Delaney <johnidel@chromium.org>
    > Reviewed-by: Josh Karlin <jkarlin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#619760}
    
    TBR=jkarlin@chromium.org,rsesek@chromium.org,johnidel@chromium.org
    
    Change-Id: Ia755a547df8982402942b3430e6680ed1e97f3a2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 878393
    Reviewed-on: https://chromium-review.googlesource.com/c/1394949Reviewed-by: default avatarTommy Steimel <steimel@chromium.org>
    Commit-Queue: Tommy Steimel <steimel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#619789}
    46010c3e
page_load_metrics.mojom 9.21 KB