GitLab

The invocation to md5_check was complex and it is easy to miss an arg.
Since compile_resources is using transitive assetres deps instead of
depending on the actual java targets, it is no longer on the critical
path and no longer needs md5_check. See below for benchmark stats.

Before (r845557):
gn args: target_os="android" use_goma=true android_fast_local_dev=true
gn gen: 7.0s
chrome_java_nosig: 34.3s avg (34.6s, 33.7s, 34.7s, 34.1s)
chrome_java_sig: 35.4s avg (35.1s, 35.4s, 35.0s, 36.2s)
chrome_java_res: 38.6s avg (38.7s, 38.6s, 38.5s, 38.7s)
base_java_nosig: 42.9s avg (42.7s, 42.9s, 43.1s, 43.1s)
base_java_sig: 106.5s avg (107.0s, 106.8s, 105.8s, 106.5s)

After:
gn args: target_os="android" use_goma=true android_fast_local_dev=true
gn gen: 6.7s
chrome_java_nosig: 33.6s avg (33.3s, 33.9s)
chrome_java_sig: 34.8s avg (34.1s, 35.5s)
chrome_java_res: 38.9s avg (38.5s, 39.3s)
base_java_nosig: 43.3s avg (43.0s, 43.6s)
base_java_sig: 106.7s avg (106.0s, 107.5s)

Bug: 1066943
Change-Id: I538a2c15ee07cf0beec23b2e0885c84b964273c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643120
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846131}