• Vladimir Levin's avatar
    cc/metrics: Fix a test-only assert failure in UMA. · 4749ce29
    Vladimir Levin authored
    This patch address an UMA assert failure. It happens because we record
    metrics with a null client in most of the tests (the metrics name is
    never set). However, some tests that verify UMA buckets do set the name.
    In those cases, UMA assert fails since the we are using a different uma
    name in the same process.
    
    The fix is to only record UMAs if we have a client name set. Ideally
    we would fix this at the test level instead, so I left a TODO.
    
    R=khushalsagar@chromium.org, ericrk@chromium.org
    
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ida6d605963d123ce683b1c1b8b9814904d17ff45
    Reviewed-on: https://chromium-review.googlesource.com/764583Reviewed-by: default avatarEric Karl <ericrk@chromium.org>
    Commit-Queue: vmpstr <vmpstr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#516069}
    4749ce29
software_image_decode_cache.cc 39 KB