• Gauthier Ambard's avatar
    Reland "Add blink effect to the PopupMenu" · 4753267b
    Gauthier Ambard authored
    This reverts commit 33c637fd.
    
    Original change's description:
    > Revert "Add blink effect to the PopupMenu"
    >
    > This reverts commit 20a94e7f.
    >
    > Reason for revert:
    > https://bugs.chromium.org/p/chromium/issues/detail?id=844753
    >
    > Bug: 844753
    >
    > Original change's description:
    > > Add blink effect to the PopupMenu
    > >
    > > This CL adds an effect to make the "New Incognito Tab" row of the tools
    > > menu blink a selected state when the in product help requires it.
    > >
    > > Bug: 829344
    > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    > > Change-Id: Ib2345a98f8ec284369b342d111cadf7f6a55adef
    > > Reviewed-on: https://chromium-review.googlesource.com/1057708
    > > Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    > > Reviewed-by: edchin <edchin@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#559481}
    >
    > TBR=edchin@chromium.org,gambard@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: 829344
    > Change-Id: I7135501ca78396a46d23ec53a538352d77e5c29d
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    > Reviewed-on: https://chromium-review.googlesource.com/1066334
    > Commit-Queue: Eugene But <eugenebut@chromium.org>
    > Reviewed-by: edchin <edchin@chromium.org>
    > Reviewed-by: Eugene But <eugenebut@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#560106}
    
    Bug: 844753, 829344
    Change-Id: Ibaf0e5cb3938a58021105d14b8d9d60e08372e06
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Reviewed-on: https://chromium-review.googlesource.com/1068727Reviewed-by: default avataredchin <edchin@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#560632}
    4753267b
BUILD.gn 4.58 KB