• Devlin Cronin's avatar
    [Extensions Bindings] Move CrazyExtensionTest.Crazy to bindings apitests · 47e79040
    Devlin Cronin authored
    CrazyExtensionTest.Crazy tests the result of calling into the app API
    of a removed context. Conceptually, this is very similar to other
    extension bindings API tests, and would benefit from constant tree
    coverage with both JS and native bindings. Move the test to the
    ExtensionBindingsApiTest suite, and have it run with both JS and native
    bindings.
    
    Additionally, the behavior for native and JS bindings is slightly
    different when accessing invalidated contexts' APIs: Native bindings
    throw an error, whereas JS bindings do not. Adjust the test expectations
    accordingly.
    
    Also rename the test to something slightly more descriptive
    (s/Crazy/UseAppAPIAfterFrameRemoval).
    
    Bug: 653596
    Test: browser_tests --gtest_filter=*UseAppAPIAfterFrameRemoval*
    
    Change-Id: Ic9c1615eda03320262d04c9760bc7879b2af78c5
    Reviewed-on: https://chromium-review.googlesource.com/898397Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#534103}
    47e79040
extension_bindings_apitest.cc 18 KB