GitLab

Previously we used the deprecated NotificationUiService::CancelAll
via BrowserCloseManager to do this. That used the MessageCenter
singleton directly, which worked with in-process Ash but not oop Ash.
By listening for profile shutdown in the NotificationPlatformBridge, we
can accomplish the same thing and it works in oop Ash as well.

This is a roundabout way of fixing the bug, which AFAICT is a race
between the Profile object shutting down and Ash asynchronously (via
mojo) notifying of a notification toast closing. I couldn't figure out
how to trigger this race, hence no direct test.

Bug: 842705
Change-Id: I5913bcb3077450433e26ba6cc7397e17211bc9a6
Reviewed-on: https://chromium-review.googlesource.com/1058491Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559175}