• Yoichi Osato's avatar
    Revert "Prepare shelf layout manager for shutdown earlier" · 48d20877
    Yoichi Osato authored
    This reverts commit 97dfeb90.
    
    Reason for revert: TabletModeControllerTest.VerticalHingeTest (CRASHED) on Linux ChromiumOS MSan Tests
    Fixed: 1044871
    
    Original change's description:
    > Prepare shelf layout manager for shutdown earlier
    > 
    > Starts shelf layout manager shutdown earlier at the beginning of shell
    > shutdown sequence (during OnShellDestroying call issued to shell
    > observers when the shell tear down starts).
    > 
    > The main goal is to prevent shelf state updates that might happen during
    > shutdown. For example, tablet mode controller destruction, and overview
    > controller destruction might cause window stacking changes, that in
    > turn can cause shelf state updates - both of which happen before
    > Shell::CloseAllRootWindowChildWindows(), which is from where
    > ShelfLayoutManager::PrepareForShutdown is currently called (with some
    > indirection).
    > 
    > NOTE: Calls to start shelf shutdown issued from
    > RootWindowController::CloseChildWindows() are kept around to handle root
    > window controller shutdowns that happen outside shell shutdown.
    > 
    > BUG=1033343
    > 
    > Change-Id: I86211392b45bdafd5f095bd60c774fe88e8accce
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015358
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#734253}
    
    TBR=xiyuan@chromium.org,tbarzic@chromium.org
    
    Change-Id: I69855c62eedfc7698df237169fc1282868d2876b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1033343
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015879Reviewed-by: default avatarYoichi Osato <yoichio@chromium.org>
    Commit-Queue: Yoichi Osato <yoichio@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#734371}
    48d20877
shelf_layout_manager.cc 104 KB