• Stephen McGruer's avatar
    Revert "OopAsh: improve immersive fullscreen for app windows" · 48d9716b
    Stephen McGruer authored
    This reverts commit 4480bf47.
    
    Reason for revert: Strong suspect for causing crashes in WidgetTest.FullscreenFrameLayout on linux-chromeos-rel
    
    Bug: 868004
    
    Original change's description:
    > OopAsh: improve immersive fullscreen for app windows
    > 
    > Immersive fullscreen for an app window almost works aside from the fact
    > that the normal frame remains when the app window is fullscreened. This
    > is a result of not updating the client area inset when the window show
    > state changes (e.g. from restored to fullscreen). The client area is
    > updated when the window bounds change, as they would when entering
    > fullscreen, but the bounds change comes through just before the state
    > change. Thus, when ClientSideNonClientFrameView checks fullscreen state
    > during layout, it still finds the widget is restored and calculates the
    > wrong bounds. The solution is to explicitly kick off a layout when
    > entering or exiting fullscreen.
    > 
    >       after launching with --enable-features=Mash --ash-dev-shortcuts
    > 
    > Test: enter and exit fullscreen on an app window with ctrl+shift+F
    > Bug: 640365
    > Change-Id: I499e29427ed072f3428de1f195ede1dc9892e71f
    > Reviewed-on: https://chromium-review.googlesource.com/1150618
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Commit-Queue: Evan Stade <estade@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#578353}
    
    TBR=sky@chromium.org,estade@chromium.org
    
    Change-Id: I2effa307fa2da94610130e6b084b6979fc4c070e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 640365
    Reviewed-on: https://chromium-review.googlesource.com/1151908Reviewed-by: default avatarStephen McGruer <smcgruer@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#578380}
    48d9716b
desktop_window_tree_host_mus.cc 33.3 KB