GitLab

All targets that need earl_grey are supposed to depend on
//ios/third_party/earl_grey:earl_grey+link, and those who depend on
//ios/third_party/earl_grey should not compile because
//ios/third_party/earl_grey doesn't have the corresponding header
search path cflags included in its public_configs, dependents don't
know where to find the generated EarlGrey.framework.

However, current code compiles because earl_grey depends on
ochamcrest+link, so dependents of earl_grey knows where to find
Ochamcrest.framework, and coincidentally, EarlGrey.framework and
Ochamcrest.framework are generated in the same directory, thus,
dependents indirectly knows where to find EarlGrey.framework.

This CL converts //ios/third_party/earl_grey to
//ios/third_party/earl_grey:earl_grey+link whereever possible, and will
have a follow up CL to generate EarlGrey.framework and
Ochamcrest.framework in different directories so that the above
mentioned error can be caught at compile time.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibec2be796aff27011689f0e342be4ec050819c39
Reviewed-on: https://chromium-review.googlesource.com/727189Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510024}