GitLab

This reverts commit fc9d1583.

Reason for revert: Now that we've branched for M68, I'm relanding this.

Original change's description:
> Revert "Surface synchronization: Add diagnostic CHECK"
> 
> This reverts commit 3fb6e543.
> 
> Reason for revert: This is blocking branch cut. We know we hit this case and we've collected some crash logs to sift through now.
> 
> Original change's description:
> > Surface synchronization: Add diagnostic CHECK
> > 
> > Current evidence points to a race in cc that is causing surface invariants
> > violations (No invariants violations detected in LayerTreeHost but detected
> > in ClientLayerTreeFrameSink).
> > 
> > My suspicion is viewport is updated out of sync with LocalSurfaceId and
> > device scale factor.
> > 
> > This CL adds a diagnostic CHECK between the pending and active LayerImpls to
> > attempt to detect the race and produce a better stack trace. The invariant
> > we want to test here is if active tree has an invalid viewport (viewport has
> > changed), then the LocalSurfaceId MUST change.
> > 
> > Bug: 672962
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I975c9dfb9c86c292d7aac052bac01510e6efb1c2
> > Reviewed-on: https://chromium-review.googlesource.com/989851
> > Reviewed-by: enne <enne@chromium.org>
> > Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#547457}
> 
> TBR=enne@chromium.org,fsamuel@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 672962
> Change-Id: Id1ad5997e12b7f966df5f7b034bd5a30baa5ae60
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1008642
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550175}

TBR=enne@chromium.org,fsamuel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 672962
Change-Id: I7e460b4177d7690cc324d0feadeed7aacbcb24ec
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1012407Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551126}