GitLab

Remove CLC::id_to_item_controller_map_; rely on ShelfModel instead.
Skip removing shelf items in CLC destruction; rely on ~ShelfModel instead.

Remove CLC::[Get|Set]ShelfItemDelegate helpers; inline ShelfModel calls.
Remove moot ShelfModelObserver::OnSetShelfItemDelegate.

Rename CLC::LauncherItemClosed -> RemoveShelfItem.
Rename test helper GetAppLaunchers -> GetPinnedAppIds.

Inline ShelfModel::RemoveShelfItemDelegate helper function.
Avoid GetItemIndexForType, use GetShelfIDForAppID instead.
Use ItemTypeIsPinned helper function.

BUG=557406
TEST=Automated; no Chrome OS shelf behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2798173002
Cr-Commit-Position: refs/heads/master@{#463030}