• Yuke Liao's avatar
    Revert "Reland DownloadTaskImpl implementation for //ios/web Download API." · 4a7ac35f
    Yuke Liao authored
    This reverts commit 220c3a64.
    
    Reason for revert: DownloadTaskImplTest.* are failing again on iOS 11 devices:
    
    For example:
    
    DownloadTaskImplTest.FailureInTheBeginning:
    ../../ios/web/download/download_task_impl_unittest.mm:321: Failure
    Value of: session_task
      Actual: false
    Expected: true
    ../../ios/web/download/download_task_impl_unittest.mm:319: Failure
    Actual function call count doesn't match EXPECT_CALL(task_observer_, OnDownloadUpdated(task_.get()))...
             Expected: to be called once
               Actual: never called - unsatisfied and active
    unknown file: Failure
    Uninteresting mock function call - returning directly.
        Function call: OnTaskDestroyed(0x101752170)
    
    Original change's description:
    > Reland DownloadTaskImpl implementation for //ios/web Download API.
    > 
    > This CL implements DownloadTask public interface.
    > 
    > DownloadControllerImpl CL: crrev.com/c/758525
    > Design doc: http://go/ios-web-download-api
    > 
    > Bug: 780646
    > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    > Change-Id: Iffea44bfb64cc945f7d899dd7181556a730394f1
    > Reviewed-on: https://chromium-review.googlesource.com/775889
    > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    > Commit-Queue: Eugene But <eugenebut@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#517424}
    
    TBR=sdefresne@chromium.org,eugenebut@chromium.org
    
    Change-Id: I254a9d8856c29bbe228a2dc96838536dd23e5a35
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 780646
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Reviewed-on: https://chromium-review.googlesource.com/777063Reviewed-by: default avatarYuke Liao <liaoyuke@chromium.org>
    Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#517485}
    4a7ac35f
BUILD.gn 17.7 KB