GitLab

Updating the cookie count every time it changes is extremely expensive (each
update causes a relayout of the page info dialog) and, worse, causes the dialog
to be unusable to screen readers. In the extreme case, JS-heavy websites cause
this dialog to be read as endless repetitions of "Cookies" as the screen reader
repeatedly cuts itself off while trying to read the changing text.

This change makes the dialog text not update; other possibilities considered
were:
* Removing the text altogether
* Collapsing the state down to "cookies in use" or "no cookies in use"

I feel that this change is less intrusive and less of a design change to the
dialog than either of those two, but one of them (especially the first, IMO) is
probably a good direction to go later.

To test this change, try https://www.washingtonpost.com: navigate to the site
with a cold cache, open the page info dialog, and watch the text change rapidly.

Bug: 984651
Change-Id: If7f996470a1768a7f9acadc72fcf13cec41a73a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853112Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705049}