• Wei Lee's avatar
    Reland "Reland "[CCA] Run CCA as SWA by default"" · 4ab7c8a2
    Wei Lee authored
    This reverts commit c946338b.
    
    Reason for revert: Reland after fixing browser tests
    
    Original change's description:
    > Revert "Reland "[CCA] Run CCA as SWA by default""
    >
    > This reverts commit 074c395f.
    >
    > Reason for revert:
    >
    > This patch landed in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21376, where three ~related `browser_test` items began failing consistently:
    >
    > * SystemFeaturesPolicyTest.DisableCameraAfterInstall
    > * SystemFeaturesPolicyTest.DisableCameraBeforeInstall
    > * ExtensionPolicyTest.ExtensionInstallBlocklistComponentApps
    >
    > These failures are really verbose, but it looks like the core is:
    >
    > ```
    > ../../chrome/browser/policy/extension_policy_browsertest.cc:401: Failure
    > Value of: registry->enabled_extensions().GetByID(extension_misc::kCameraAppId)
    >   Actual: false
    > Expected: true
    > ```
    >
    >
    >
    > Original change's description:
    > > Reland "[CCA] Run CCA as SWA by default"
    > >
    > > This reverts commit 5dec0310.
    > >
    > > Reason for revert: LKGM update: crbug.com/1148527
    > >
    > > Original change's description:
    > > > Revert "[CCA] Run CCA as SWA by default"
    > > >
    > > > This reverts commit 46b6fd15.
    > > >
    > > > Reason for revert:
    > > >
    > > > camera.CCAUISmoke.fake is failing on chromeos-eve-chrome and camera.CCAUI* is listed as test coverage for this CL, so I am speculating that it is the cause. See:
    > > > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11136
    > > >
    > > > Original change's description:
    > > > > [CCA] Run CCA as SWA by default
    > > > >
    > > > > Bug: b/172345161
    > > > > Test: tast run [DUT] camera.CCAUI*
    > > > > Change-Id: I10484c9263f3e4c560028aef272cd3db88c47b31
    > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509834
    > > > > Commit-Queue: Wei Lee <wtlee@chromium.org>
    > > > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    > > > > Auto-Submit: Wei Lee <wtlee@chromium.org>
    > > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    > > > > Cr-Commit-Position: refs/heads/master@{#825657}
    > > >
    > > > TBR=ortuno@chromium.org,wtlee@chromium.org
    > > >
    > > > Change-Id: I5464fbcd7f1a03cd157122ad66c6ee13ad111630
    > > > No-Presubmit: true
    > > > No-Tree-Checks: true
    > > > No-Try: true
    > > > Bug: b/172345161
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529360
    > > > Reviewed-by: Henrik Boström <hbos@chromium.org>
    > > > Commit-Queue: Henrik Boström <hbos@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#825818}
    > >
    > > TBR=hbos@chromium.org,ortuno@chromium.org,wtlee@chromium.org
    > >
    > > Bug: b/172345161
    > > Change-Id: Ie6d18656a2b247d8eec260319594e7355337c5af
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547645
    > > Reviewed-by: Wei Lee <wtlee@chromium.org>
    > > Reviewed-by: Shik Chen <shik@chromium.org>
    > > Commit-Queue: Wei Lee <wtlee@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#829079}
    >
    > TBR=shik@chromium.org,hbos@chromium.org,ortuno@chromium.org,wtlee@chromium.org
    >
    > Change-Id: I31ad4e34332a5c54a0a4bd2c2f98dfe7e6544016
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: b/172345161
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549842
    > Reviewed-by: Mike West <mkwst@chromium.org>
    > Commit-Queue: Mike West <mkwst@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#829154}
    
    TBR=shik@chromium.org,hbos@chromium.org,ortuno@chromium.org,mkwst@chromium.org,wtlee@chromium.org
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: b/172345161
    Change-Id: I752d3919a2e7de9a43c2e8271b7f8e83509db84f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549203Reviewed-by: default avatarWei Lee <wtlee@chromium.org>
    Reviewed-by: default avatarJulian Pastarmov <pastarmovj@chromium.org>
    Commit-Queue: Wei Lee <wtlee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#829221}
    4ab7c8a2
chromeos_features.cc 36.4 KB