• Mohamed Mansour's avatar
    Reland Fix Crash in Hung Pages view while in screen reader · 4b32d39c
    Mohamed Mansour authored
    There seems to be a timing issue between the AX queries for
    GetText and when the model is updating. Looking at the model
    it seems not all TabDestroyed calls are informing the Observers
    that the model has changed.
    
    The TableView uses Virtual AX Children that depends on the
    observers to call. Moved the observer call to the Reset to satisfy
    all other cases where the Hung Pages Modal gets fired in:
    
     - RenderProcessExited
     - RenderWidgetHostDestroyed
     - TabDestroyed,
     - RenderViewHostChanged
     - WebContentsDestroyed
    
    Bug: 1140454
    Change-Id: I4e5b375acb351f5338faff3f30b65b38fc834818
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545050Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Commit-Queue: Mohamed Mansour <mmansour@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#829021}
    4b32d39c
hung_renderer_view.cc 16.7 KB