• A Olsen's avatar
    Move cryptohome callbacks for InSessionPwChange to manager singleton · 4b7373f8
    A Olsen authored
    The class InSessionPasswordChangeHandler manages a dialog where the
    user can change their password in-session. If cryptohome password
    migration fails, then the handler is notified via a callback. This
    callback is where we would help the user to solve the problem.
    
    However, the Handler object will not outlive the dialog, so if the
    user closes the dialog, then the callback will not be called, and
    the password change will never be fully completed.
    
    To fix this problem, this CL moves the callbacks to a
    PrimaryProfileService - the InSessionPasswordChangeManager.
    No actual functionality is changed - it just means that these
    callbacks (which don't yet do a lot) will still be called even
    if the dialog is closed.
    
    Bug: 930109
    Change-Id: I520744406251645c6a98b4ea20acd5a19088d1d8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655649
    Commit-Queue: A Olsen <olsen@chromium.org>
    Reviewed-by: default avatarColin Blundell <blundell@chromium.org>
    Reviewed-by: default avatarLutz Justen <ljusten@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#670203}
    4b7373f8
BUILD.gn 132 KB