• Regan Hsu's avatar
    [CrOS PhoneHub] Add BrowserTabsModel controller and provider and edits. · 4c09dc65
    Regan Hsu authored
    The controller sets the MutablePhoneModel using info observed from the
    the provider class. The provider get browser tab info via SyncedSession
    (available via SessionService) with a |session_name| that matches the
    |pii_free_name| of the phone provided by a MultiDeviceSetupClient.
    If sync is enabled, the class uses a BrowserTabsMetadataFetcher to
    actually fetch the browser tab metadata once it finds the correct
    SyncedSession.
    
    This CL also replaces FaviconService with HistoryUiFaviconRequestHandler
    because FaviconService often fails at fetching the favicon.
    
    HistoryUiFaviconRequestHandler, from manual testing, has always
    succeeded. This is because HistoryUiFaviconRequestHandler fetches
    favicons from google servers instead of the endpoint directly. If
    it can't find one on google server, it fetches the favicon from the url
    and caches it on the server.
    
    Bug: 1106937
    Change-Id: Id2f4949b344d7685a814b7635d2f7986117d10ff
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427297
    Commit-Queue: Regan Hsu <hsuregan@chromium.org>
    Reviewed-by: default avatarRegan Hsu <hsuregan@chromium.org>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#813463}
    4c09dc65
phone_hub_manager_impl.cc 5.72 KB