-
chrome://media-appDavid authored
Currently we are intending to launch with the existing gallery icon. This cl adds all the resolutions of the * our app icon to our manifest.json * the gallery icon to our resources file (media_app_resources.grd). Points our app icons i.e. "system_assets/app_icon_*.png" to the gallery icons. When we add our own app icon b/141588875, we don't need to change our manifest.json file. We would just need to: * remove IDR_MEDIA_APP_GALLERY_ICON_*_PNG from media_app_resources.grd * add resources for our app icon to our internal resource file media_app_bundle_resources.grd. * update our resource paths in media_app_ui.cc to point at our resources from media_app_bundle_resources.grd (might need to do this from the guest context). or if we ship the icon to chromium just update IDR_MEDIA_APP_GALLERY_ICON_*_PNG to point at the new icon location. Note: some follow up work needed to get this working for rendering the right resolution for the taskbar crbug/1110768. Bug: b/161203411, 996088 Change-Id: I0988dbb3eaeb0eaf029c49a1643ceed85acd8715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325471 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#792610}
9cfaae35