• Alexey Baskakov's avatar
    WebApp: Use InstallWebAppsAfterSync method in unit tests. · 4c48069a
    Alexey Baskakov authored
    WebAppInstallManager::InstallBookmarkAppFromSync will be a special
    method to support online compatibility with bookmark apps.
    
    Let's use InstallWebAppsAfterSync to test:
    1) TwoConcurrentInstallsAreRunInOrder
    2) InstallManagerDestroyed
    cases. These tests are not about InstallBookmarkAppFromSync directly,
    they test internal WebAppInstallManager queue of tasks and a lifetime.
    That's why it's okay to change them.
    
    As a result, all WebAppInstallManager unit tests pass even if
    kDesktopPWAsWithoutExtensions is enabled by default.
    
    Note: web_app_install_manager_unittest.cc works as if
    kDesktopPWAsWithoutExtensions is enabled: it has a BMO registry in
    its test fixture.
    
    Bug: 1020037
    Change-Id: I4b0d008e023ee2d60cf56aad9cc0270bb17f747d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094921
    Commit-Queue: Alexey Baskakov <loyso@chromium.org>
    Reviewed-by: default avatarAlan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#749547}
    4c48069a
web_app_install_manager.cc 13.4 KB