• Antonio Gomes's avatar
    Merge blink-specific media_devices typemap into the original (1/2) · 4c4e51e7
    Antonio Gomes authored
    This is the first step to unify media_devices.typemap and
    media_devices_for_blink.typemap. Basically, the former will be
    used as-is from Blink when the work done.
    
    Note that, the approach could have been backwards, ie use
    blink.mojom.MediaDeviceTypes throughout the code and remove
    blink::MediaDeviceTypes, however that would result in a way
    bigger CL (see [1] for reference), since today blink::MediaDeviceTypes
    enum item are used mainly for indexing vectors, and
    blink::mojom::MediaDeviceTypes class enum items can be implicitly
    converted to int, for similar purposes.
    
    [1] https://crrev.com/c/2106015
    
    Since 'blink::mojom::MediaDeviceTypes type' parameter is actually
    unused in blink::MediaDevices::OnDevicesChange(), it is possible to
    consider removing the parameter and the blink.mojom.MediaDeviceTypes
    definition altogether from media_devices.mojom.
    
    BUG=704136
    R=guidou@chromium.org
    
    Change-Id: Id3d42c3bbde30a7dd02b92439b867764e4211073
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105794Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#750922}
    4c4e51e7
media_devices.h 5.28 KB