• Joel Hockey's avatar
    Do not bind web_contents directly in OnArcHandled · 4c772209
    Joel Hockey authored
    It seems that web_contents may be destroyed during
    RunArcExternalProtocolDialog (See TODO comment in the code).
    See crashes in crbug.com/1136237
    
    So rather than bind web_contents directly into OnArcHandled(), we use
    render_process_host_id and routing_id to look it up at the end as was
    happening in ShowFallbackEternalProtocolDialog() prior to
    crrev.com/c/2423067.
    
    Bug: 1136237
    Change-Id: If0bc1287f9eedbf2b915cd97e049a19f379254ec
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460067
    Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Auto-Submit: Joel Hockey <joelhockey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#815200}
    4c772209
external_protocol_dialog.cc 5.46 KB